Skip to content

Conversation

@andrewdnolan
Copy link
Collaborator

This PR makes recursively traversing the path provided (if it's a directory) optional.

Given the current automatic recursion, as part of unified deployments we see:

Updating file permissions for: /global/common/software/e3sm/anaconda_envs/test_e3sm_unified_1.12.0rc3_pm-cpu.csh                                                                          
Updating file permissions for: /global/common/software/e3sm/anaconda_envs/test_e3sm_unified_1.12.0rc3_pm-cpu.sh                                                                           
Updating file permissions for: /global/common/software/e3sm/anaconda_envs/e3smu_1_12_0rc3/pm-cpu   

Without the ability to toggle the recursion, we have no way to update the permissions for the:

 /global/common/software/e3sm/anaconda_envs/e3smu_1_12_0rc3

directory. We don't want to traverse that directory recursively, because some machines share a file system and there will be multiple machine entries within there. This allows us to update, without iterating over all the machine directories within there.

Checklist

  • Testing comment, if appropriate, in the PR documents testing used to verify the changes

@andrewdnolan andrewdnolan requested a review from xylar October 30, 2025 19:07
@andrewdnolan andrewdnolan changed the title Make recursived permission updates optional Make recurisve permission updates optional Oct 30, 2025
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this makes sense.

@xylar xylar merged commit a9aa894 into E3SM-Project:main Oct 31, 2025
5 checks passed
@xylar xylar self-assigned this Oct 31, 2025
@xylar xylar added the enhancement New feature or request label Oct 31, 2025
@andrewdnolan andrewdnolan deleted the toggle-recursive-perm-updates branch November 3, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants